getDefinitionAtPosition doesn't distinguish different kinds in a merged declaration · Microsoft/TypeScript#22467

(13 评论) (0 反应) (0 负责人)TypeScript (48,455 star) (6,726 fork)batch import

BugDomain: APIGood First IssueHelp Wanted

描述

TypeScript Version: 2.7.2

Search Terms: getDefinitionAtPosition kind

Code

namespace A { export interface B {} }
class A {}
interface A {}

var x: A; // do getDefinitionAtPosition on the A reference here

Expected behavior: In the result, each of the individual declarations should have the appropriate kind:

[
    { fileName: 'test.ts', textSpan: { start: 10, length: 1 }, kind: 'module', name: 'A', ... },
    { fileName: 'test.ts', textSpan: { start: 44, length: 1 }, kind: 'class', name: 'A', ... },
    { fileName: 'test.ts', textSpan: { start: 59, length: 1 }, kind: 'interface', name: 'A', ... }
]

Actual behavior: All declarations have the same kind:

[
    { fileName: 'test.ts', textSpan: { start: 10, length: 1 }, kind: 'class', name: 'A', ... },
    { fileName: 'test.ts', textSpan: { start: 44, length: 1 }, kind: 'class', name: 'A', ... },
    { fileName: 'test.ts', textSpan: { start: 59, length: 1 }, kind: 'class', name: 'A', ... }
]

贡献者指南

技术栈: typescript
领域: tooling
议题类型: bug
难度: 4
预计时间: 3-5 days
活动状态: stale
清晰度: clear
前置要求: Understanding of TypeScript's symbol and declaration mergingFamiliarity with getDefinitionAtPosition
新手友好度: 25
研究方向: Examine the implementation of getDefinitionAtPosition, likely in src/services/utilities.ts or src/services/textChanges.ts. Understand how it iterates over declarations of a merged symbol and assigns the `kind` field. The bug is that it uses the same kind for all declarations; fix by mapping each declaration's individual kind. Refer to the code example and expected JSON in the issue.