Microsoft/TypeScript

Assignments to global objects in Javascript should be global declarations

Open

#22,446 创建于 2018年3月9日

在 GitHub 查看
 (3 评论) (0 反应) (0 负责人)TypeScript (48,455 star) (6,726 fork)batch import
BugDomain: JavaScriptEffort: ModerateExperience EnhancementHelp WantedRescheduled

描述

// @noEmit: true
// @allowJs: true
// @checkJs: true
// @Filename: a.js
global.x = 1
window.y = 2
this.z = 3

var n = x + y + z

Expected behavior: No error, and x, y and z are visible globally.

Actual behavior: Errors:

  1. Can't find name 'global'
  2. 'Window' has no property 'y'
  3. Cannot find name 'x', 'y' or 'z'

Ideally, global should only be visible when targetting node and window should only be visible when targetting the browser. It's not a requirement, though.

贡献者指南

技术栈
typescriptjavascript
领域
tooling
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
4
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
3-5 days
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
TypeScript basicsGlobal scope concepts
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
30
研究方向
Investigate how the TypeScript compiler handles global assignments in .js files with checkJs enabled. Examine the type checker (src/compiler/checker.ts) to understand why 'global' is not recognized as a global object and why assignments to 'window' and 'this' are not treated as global declarations. Look at existing tests in tests/cases/... The issue provides a minimal reproduction; the fix likely involves updating the handling of global property assignments in JavaScript mode.