Microsoft/TypeScript

Gracefully handle template literal properties in the parser

Open

#1,057 创建于 2014年11月4日

在 GitHub 查看
 (0 评论) (2 反应) (0 负责人)TypeScript (48,455 star) (6,726 fork)batch import
Domain: Error MessagesEffort: ModerateExperience EnhancementHelp Wanted

描述

var x = {
    a: "Hello"
    `b`: 123
}

Right now, the parser encounters the template string, decides it should bail out of object literal parsing, and we more or less recover thinking we have something like the following:

var x = ({ a: "Hello" } `b`) : 123 }

So we'll report an error on what we think is:

{ a: "Hello" } `b`
  • On the syntactic layer under ES5 mode, we'll say tagged templates are not supported unless in ES6.
  • On the semantic layer, we'll say { a: "Hello" } is not invokable.

贡献者指南

技术栈
typescript
领域
backendtooling
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
4
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-2 days
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
Understanding of TypeScript's parserFamiliarity with object literal parsing
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
20
研究方向
Investigate the parser (likely in `src/compiler/parser.ts`) to understand how object literal properties are parsed and how template literals are treated. The issue describes that encountering a template literal in an object literal causes the parser to bail out incorrectly. Look for the code that handles property names and template literals. Consider adding a check to gracefully handle template literal properties by either parsing them as computed property names or generating a proper error message. Analyze the token stream to differentiate between a tagged template and a property template literal.