Formatter fails to format uglified files · Microsoft/TypeScript#10126

(2 评论) (0 反应) (0 负责人)TypeScript (48,455 star) (6,726 fork)batch import

Domain: FormatterHelp WantedSuggestionVS Code Tracked

描述

TypeScript Version: 1.8.10

I use vscode from the Command Palette to format a javascript file uglified by uglify-js, but it failed. It not format code correctly, and only format partially.

source file 2016-07-12 4 47 08

sublime jsFormat formated 2016-07-12 4 47 29

vscode formated 2016-07-12 4 47 45

You see, It seems like, vscode only add some spaces around brackets, letters, commas etc.

See https://github.com/Microsoft/vscode/issues/8914#issuecomment-231978337 and the discussion below for more details. The provided traces clearly show that the tsserver only returns white space (" ") changes. No insertion of new lines.

贡献者指南

技术栈: typescriptjavascript
领域: developer experiencetooling
议题类型: bug
难度: 3
预计时间: 1-2 days
活动状态: stale
清晰度: mostly clear
前置要求: Basic understanding of TypeScript's formatter internals
新手友好度: 10
研究方向: Investigate the TypeScript formatter source code, likely in src/services/formatting/, to understand how it handles whitespace and line breaks. The issue indicates that the formatter only inserts spaces but not new lines for minified code. Reproduce with a uglified JS file and trace the formatting output. Look for relevant tests or linked issues like https://github.com/Microsoft/vscode/issues/8914 for additional context.