Meteor-Community-Packages/meteor-roles

Internal function _getInheritedRoleNames() should return role object

Open

#304 创建于 2019年12月10日

在 GitHub 查看
 (0 评论) (0 反应) (0 负责人)JavaScript (919 star) (161 fork)batch import
enhancementgood first issue

描述

https://github.com/Meteor-Community-Packages/meteor-roles/blob/32c230ded9cb92b27a3485d143cabf2732fef186/roles/roles_common.js#L543-L557

The function _getInheritedRoleNames() is currently used to construct the array inheritedRoles on a role-assignment, where it only takes over the parameter _id. If you have data stored on the role, wouldn't it be better to have it copied along?

If one of these parameter changes, the programmer extending this package would then be responsible for also keeping this data updated there. If he doesn't need it there, he can extend this package wrapping this function to remove the additional properties.

贡献者指南

技术栈
javascriptnodejsmongodb
领域
authorization
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
under 1 hour
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
JavaScriptMeteor
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
70
研究方向
Examine the ` getInheritedRoleNames()` function in `roles/roles common.js` (lines 543–557). Understand how it currently returns only role names and how the `inheritedRoles` array is constructed. Consider modifying the function to return the full role object so that additional properties are preserved. Evaluate the impact on callers and ensure backward compatibility or provide an option.