MetaMask/metamask-extension

Replace deprecated CheckBox component with Checkbox from the component-library

开放

#20,163 创建于 2023年7月24日

 (7 条评论) (0 个反应) (0 位负责人)JavaScript (4,848 个派生)batch import
good first issueteam-design-system

仓库指标

星标
 (11,014 个星标)
PR 合并指标
 (PR 指标待抓取)

描述

Description

Currently, the extension is using an outdated CheckBox component, which needs to be replaced with the new Checkbox component.

This is a massive undertaking by itself and creating a single PR would be too large. Smaller PRs can be submitted against this issue to ensure easier review and gradual improvements.

Technical Details

  • Replace instances of CheckBox component (ui/components/ui/check-box/check-box.component.js) with Checkbox component (ui/components/component-library/checkbox/checkbox.tsx)
  • Component APIs are slightly different so ensure all props have been migrated appropriately

Acceptance Criteria

  • Instances of Checkbox component are completely replaced with the new Checkbox component
  • The component APIs are updated to reflect the changes in the new Checkbox component and there is no functional changes or visual regression
  • Each Pull Request (PR) should include no more than 3 files
  • The code changes should pass Jest tests, linting, and Storybook without any errors.
  • The PR must include before and after screenshots of the UI to ensure there are no visual regressions.

If the acceptance criteria is not met, PRs may be closed.

Difficulty: Intermediate

Good first issue for: External contributors who are familiar with running the extension locally, have knowledge of React, component props, Jest tests, linting, and Storybook, and want to contribute to improving the cohesiveness of UI in the extension

贡献者指南