MetaMask/metamask-extension

Replace deprecated Box component with new Box component

Open

#19,526 创建于 2023年6月8日

在 GitHub 查看
 (6 评论) (0 反应) (0 负责人)JavaScript (11,014 star) (4,848 fork)batch import
INVALID-ISSUE-TEMPLATEgood first issueteam-design-system

描述

Description

Currently, the extension is using an outdated Box component, which needs to be replaced with the new Box component from @metamask/design-system-react.

This is a massive undertaking by itself and creating a single PR would be too large. Smaller PRs can be submitted against this issue to ensure easier review and gradual improvements. PRs should contain no more than 3 files

Technical Details

  • The old Box component (ui/components/ui/box/box.js)
  • The new Box component from @metamask/design-system-react (documentation)
  • Component APIs should be the same so minimal changes should be needed in the code that uses the Box component.

Acceptance Criteria

  • The old Box component (ui/components/ui/box/box.js) is completely replaced with the new Box component from @metamask/design-system-react throughout all files included in the PR.
  • The component APIs are updated to reflect the changes in the new Box component.
  • Each Pull Request (PR) should include no more than 3 files with Box replacements.
  • The code changes should pass Jest tests, linting, and all CI checks without any errors.
  • The PR must include before and after screenshots of the UI to ensure there are no visual regressions.

If the acceptance criteria are not met, PRs may be closed.

Difficulty: Intermediate

Good first issue for: External contributors who are familiar with running the extension locally, have knowledge of React, component props, Jest tests, linting, and Storybook, and want to contribute to improving the cohesiveness of UI in the extension

贡献者指南