Maakaf/friends-activity-backend
refactor - github service - inject octokit and use abstraction level to remove coupling
开放
#56 创建于 2025年10月30日
hacktoberfest
仓库指标
- 星标
- (9 个星标)
- PR 合并指标
- (30 天内没有已合并 PR)
描述
while trying to write the more "interesting" utests for GithubService, i came to realize that it would be a lot easier to mock and test if octokit (and Logger for that matter) would be injected.
So i would like to refactor the service such that it expects an abstraction and use octokit to implement it. this would:
- enable easier mocking in utests.
- remove strong couling we have today between octokit and github service.
@UrielOfir @barlavi1 @Lidor57 - any thoughts about this ?