Lightning-AI/pytorch-lightning

Make logging_mode (`on_step` or `on_epoch`) available to loggers

Open

#20,502 创建于 2024年12月17日

在 GitHub 查看
 (5 评论) (0 反应) (0 负责人)Python (26,687 star) (3,233 fork)batch import
featurehelp wanted

描述

Description & Motivation

Lightning lets you log on_step, or on_epoch. However, even when using on_epoch, the global step is logged on the x-axis, not the epoch number.

Loggers can manually extract epoch from the logged metrics and pass that as the step. However, this would break on_step logging.

Making the logging mode for a logging call available would let loggers conditionally use either the global_step or current_epoch as the step for that particular metric.

Pitch

No response

Alternatives

No response

Additional context

No response

cc @lantiga @borda

贡献者指南

技术栈
pythonpytorch
领域
machine learningdeveloper experience
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
half day
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
fresh
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
PythonPyTorchLightning logging API
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
60
研究方向
Investigate the Logger base class in the Lightning codebase, specifically how metrics are passed to loggers (e.g., the `log` method). Look at the `LightningLoggerBase` class and how `global step` and `current epoch` are currently used. Determine where the logging mode is available and how it can be exposed to loggers. Review any related issues or comments in this thread for additional context.
Make logging_mode (`on_step` or `on_epoch`) available to loggers · Lightning-AI/pytorch-lightning#20502 | Good First Issue