LedgerHQ/ledger-live-desktop

Websocket Proxy passthrough

Open

#1,073 创建于 2018年7月12日

在 GitHub 查看
 (46 评论) (0 反应) (0 负责人)JavaScript (955 star) (326 fork)batch import
feature requestgood first issue

描述

Ledger Live Version and Operating System

  • Ledger Live 1.0.1
  • Platform: linux

When the manager is opened, ledger live checks Internet connectivity.

If I have a proxy (configured via environment variables), the program does not detect that connectivity, it shows a red message “Oops, internet seems down” and offers to retry; which never detects it (see attached screenshot ledger-live.proxy-netdown.png).

On my squid3 logs I have messages like this one: “TAG_NONE/400 4062 NONE error:invalid-request - HIER_NONE/- text/html”

If I unset proxy environment variables, then network detection, and the program, works fine.

I could attach application.log if you need it, I’m guessing you won't since I've been able to reproduce it on two different computers (one with debian sid, the other with debian stretch, both updated to date).

Thanks ledger-live proxy-netdown

贡献者指南

技术栈
javascriptnodejs
领域
desktopbackend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-2 days
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
knowledge of proxy configurationbasic Node.js debugging
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
30
研究方向
The issue describes a failure to detect internet connectivity when using a proxy. The fix likely involves inspecting the network detection code, which may use WebSocket or HTTP requests. Look for the connectivity check function, possibly in the main process of the Electron app, and ensure it respects environment proxy variables (HTTP PROXY, HTTPS PROXY, NO PROXY). The root cause may be that the WebSocket client or HTTP agent is not configured to use the proxy. Check the application's network stack and consider using a library like 'global agent' or configuring the agent manually. The issue has not been addressed, so first confirm if the problem is still reproducible in the current codebase.
Websocket Proxy passthrough · LedgerHQ/ledger-live-desktop#1073 | Good First Issue