validation may not work when relying only on parseInputAttributes · Knockout-Contrib/Knockout-Validation#520

(0 评论) (0 反应) (0 负责人)JavaScript (1,024 star) (394 fork)batch import

bughelp wanted

描述

When parseInputAttributes: true and the observable is not validatable the input does not get a validation message inserted, nor the validation class validationElement.

The problem is in the validationCore binding as it asynchronously executes parseInputValidationAttributes. The later method will make the observable validatable if it matches some criteria (eg. input type is number/email, has a required attribute etc.)

Solutions:

execute parseInputValidationAttributes synchronously - this adds some overhead when bindings are applied.
duplicate code in the validationCore binding to ensure config.insertMessages and config.decorateInputElement are applied if the observable becomes validatable.

I've created a fiddle for this - it has both the solutions and some intructions on how to fix it. The interesting code starts at line 1016 in the JavaScript panel of JSFiddle.

http://jsfiddle.net/3594jm1o/

Any thoughts?

贡献者指南

技术栈: javascript
领域: frontend
议题类型: bug
难度: 2
预计时间: 1-3 hours
活动状态: stale
清晰度: clear
前置要求: Knockout.js fundamentalsJavaScript async basics
新手友好度: 50
研究方向: Review the JSFiddle link (http://jsfiddle.net/3594jm1o/) which contains both proposed solutions and instructions starting at line 1016. The bug is in the `validationCore` binding where `parseInputValidationAttributes` is called asynchronously, causing insertMessages and decorateInputElement to be missed. Examine the code in the repository's validationCore.js file to understand the current async flow and implement either synchronous execution of parseInputValidationAttributes or duplicate the config logic after the async call. The issue is open with no comments or PRs, so no prior work to consider.