JuliaPluto/Pluto.jl

ExpressionExplorer: `global` stronger than `let`

Open

#1,856 创建于 2022年1月26日

在 GitHub 查看
 (2 评论) (0 反应) (0 负责人)Julia (5,295 star) (329 fork)batch import
backendbugexpression explorergood first issue

描述

We have a couple of combinations of let and global that are not analyzed correctly, like:

let
	a = 1
	global a = 2
end

defines a global a, but Pluto prioritizes the let block.

@test_broken means that we still need to fix it:

https://github.com/fonsp/Pluto.jl/blob/c1d23122845e7864ef3dfe15a8428366c98f95eb/test/ExpressionExplorer.jl#L368-L379

This is a good first issue, because the ExpressionExplorer is a small, isolated part of Pluto's codebase. For more info about working on this issue, see:

https://github.com/fonsp/Pluto.jl/blob/c1d23122845e7864ef3dfe15a8428366c98f95eb/test/ExpressionExplorer.jl#L3-L17

贡献者指南

技术栈
无
领域
tooling
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
fresh
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Julia basicslet vs global scoping
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
80
研究方向
Examine the `test/ExpressionExplorer.jl` file around lines 368-379 where `@test broken` is used. Understand the expected scoping behavior and identify the code in the ExpressionExplorer that handles `let` and `global` statements, then implement the fix and uncomment the test.