JuliaPlots/Plots.jl

[FR] `append!` cannot accept collections (as would be expected from the name)

Open

#4,825 创建于 2023年9月19日

在 GitHub 查看
 (2 评论) (0 反应) (0 负责人)Julia (1,943 star) (381 fork)batch import
enhancementgood first issue

描述

The signature of the append! method through which all others pass accepts only Real..., meaning it cannot actually add multiple datapoints to a series. It is my understanding that in Julia, append! is generally meant to be the bulk equivalent of push!, but because of this signature, append! for plots is just a less flexible version of push!.

The problematic method definition: https://github.com/JuliaPlots/Plots.jl/blob/7cd27c470e10d8364ab935935eb58a97eae55ce3/src/utils.jl#L810C1-L810C90 image

If I understand correctly, just making the type of args less restrictive, to include vectors, would fix this. The signature of the previous method should probably also be changed for consistency but that would be a breaking change.

贡献者指南

技术栈
无
领域
data
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
under 1 hour
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Julia programming basicsUnderstanding of method signaturesFamiliarity with Plots.jl
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
75
研究方向
The issue points to a specific method definition in src/utils.jl at line 810, where the signature restricts args to Real. The fix involves changing the type to accept collections (e.g., Vector). However, this could break other callers, so examine all uses of the method. Also check the previous method definition for consistency. The maintainer may have opinions on the best approach.