JuliaDynamics/RecurrenceAnalysis.jl

Source code clarity of `recurrence_matrix`

开放

#136 创建于 2022年5月22日

 (0 条评论) (0 个反应) (0 位负责人)Julia (16 个派生)auto 404
claritygood first issue

仓库指标

星标
 (50 个星标)
PR 合并指标
 (PR 指标待抓取)

描述

At the moment the source code of recurrence_matrix, which is where the central computations of a recurrence matrix take place, is full of duplication. There version complexity scales as 2 x 2 x 2 = 8, with a multiplicity of 2 for (recurrences vs cross-recurence), (parallel vs non parallel), (dataset vs vector).

I do not believe that having 8 different methods is necessary. In fact, it may even be that we could do everything with 1 or 2 methods, by defining smaller helper functions.

In any case, a multiplicity of 8 is certainly not necessary and the source code can be simplified to remove duplication and thus make long term maintanance also easier.

贡献者指南