JuliaDynamics/DrWatson.jl

Savename expand for nested structs is not working

Open

#215 创建于 2020年11月19日

在 GitHub 查看
 (1 评论) (0 反应) (0 负责人)Julia (915 star) (94 fork)batch import
buggood first issuesavename

描述

As savename works for structs, I think it should also be possible to expand them. This doesn't work at the moment because of https://github.com/JuliaDynamics/DrWatson.jl/blob/1eece239953ab2a5aa6de1c9cb67236df0665264/src/naming.jl#L119 which, unless defined for the struct, throws an error for non-iterable types.

贡献者指南

技术栈
无
领域
databackend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Julia basicsFamiliarity with DrWatson.jl
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
60
研究方向
The issue points to line 119 in src/naming.jl where the savename function assumes structs are iterable. Nested structs may not be iterable, causing errors. Investigate the current implementation and consider adding a fallback using Base.fieldnames or similar to expand non iterable structs. Check if there's existing handling for other types and ensure backward compatibility.