JanusGraph/janusgraph

Rollback documentation and code inconsistency

Open

#1,077 创建于 2018年5月21日

在 GitHub 查看
 (2 评论) (0 反应) (0 负责人)Java (1,137 fork)batch import
Hacktoberfestarea/docshelp wanted

仓库指标

Star
 (4,985 star)
PR 合并指标
 (平均合并 3天 18小时) (30 天内合并 12 个 PR)

描述

There is a sentence in the transactions' documentation:

If a commit() transactions fails, it should be terminated manually with rollback() after catching the failure.

And there is a code of commit() implementation:

try {
    if (this.hasModifications()) {
        this.graph.commit(this.addedRelations.getAll(), this.deletedRelations.values(), this);
    } else {
        this.txHandle.commit();
    }

    success = true;
} catch (Exception var9) {
    try {
        this.txHandle.rollback();
    } catch (BackendException var8) {
        throw new JanusGraphException("Could not rollback after a failed commit", var9);
    }

    throw new JanusGraphException("Could not commit transaction due to exception during persistence", var9);
}

As I see here, the rollback() is called if commit() is failed. I think that the documentation should say: If a commit() transactions fails, it will be terminated automatically with rollback() or something like that. Maybe some clarification should be put there.

贡献者指南