INRIA/spoon

Feature(CtPackage): Implement null object for CtPackage

开放

#3,705 创建于 2020年11月19日

 (9 条评论) (0 个反应) (0 位负责人)Java (383 个派生)github user discovery
featuregood first issuerefactor

仓库指标

星标
 (1,933 个星标)
PR 合并指标
 (平均合并 19天 11小时) (30 天内合并 49 个 PR)

描述

Problem

Sometimes code elements have no package and getPackage return nulls. This introduces null checks and surprises for new developers. https://github.com/INRIA/spoon/commit/84c84e16163ff18611f82c69d5246d642e3fed86 as seen here, package can be null.

Solution

A null object[0],[1] could improve code quality. A comparable implementation is NoSourcePosition. NoSourcePosition removed all null checks for positions and improves the code quality.

Your task

Design a null object and refactor old code. Find a solution for getSimpleName() as the empty String is reserved for default package. The PR should include:

  • Design a null object for CtPackage
  • Improve already existing test code and remove unnecessary null checks

It's a good starter issue, feel free to give it a try and ping if you need help for some design decisions.

Literatur/Links

[0] https://en.wikipedia.org/wiki/Null_object_pattern [1] https://www.baeldung.com/java-null-object-pattern

贡献者指南