HabitRPG/habitica

Removing user from party does not prompt a check on whether a pending quest can start

Open

#11,566 创建于 2019年11月22日

在 GitHub 查看
 (4 评论) (0 反应) (1 负责人)JavaScript (10,775 star) (3,912 fork)batch import
help wantedpriority: minorsection: Party Page

描述

Jorayaho @Jorayaho (ab9c48bb-6b86-48dc-b3da-4fd0bac6a89c) [web] Hi, I just encountered an issue with a quest. 3 out of 4 party members accepted the quest invitation. I kicked the one who didn't accept. Quest didn't force-start (maybe the check if force-start is needed is only executed when a member accepts/declines) and when I started it manually it said not all party members accepted, only 3 out of 3.

Not yet tested; if anyone does have the chance to test this and confirm, that would be appreciated.

贡献者指南

技术栈
javascriptnodejsmongodb
领域
backend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
blocked
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Node.jsMongoDBknowledge of Habitica's quest system
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
35
研究方向
Investigate the quest start logic in the party model. Look at the function that triggers quest start upon member acceptance/decline. Check if there is a similar trigger when a member is removed. Examine files such as 'models/party' or 'controllers/quest' to understand the flow. Consider adding a check after removal to see if all remaining members have accepted and if the quest can start.