GroceriStar/groceristar-fetch

update at getGroceriesWithDepIngKey tests

开放

#217 创建于 2019年2月9日

 (2 条评论) (0 个反应) (0 位负责人)JavaScript (16 个派生)auto 404
enhancementgood first issuehelp wantedin-progresstests

仓库指标

星标
 (8 个星标)
PR 合并指标
 (30 天内没有已合并 PR)

描述

file: https://github.com/GroceriStar/groceristar-fetch/blob/master/projects/GroceriStar/getGroceriesWithDepIngKey.test.js

  • tests that checking properties - move to a separated function. you can read our other test files and find a solution.

  • Right now these tests didn't cover a lot of cases. Try to jump on grocery.json and delete an id property. Try to delete name, make name an empty string. Delete all data from one object, only keep id, name(no departments, no ingredients inside)

  • ingredients for grocery lists stored at Ingredients folder. they connected via file name. just delete one of the files, that should be connected to grocery and you wouldn't see an error.

  • Test Deep structure takes 6000ms how to reduce this number?

  • we have test Ingredient by length? WTF it's doing and why we need it - please explain.

  • making grocery list name as empty string didn't generate an error

@shubhamrajput it's for you

贡献者指南