GreenStepsChatt/greensteps

Show matcher should be scoped to the expected object

开放

#20 创建于 2017年9月21日

 (0 条评论) (0 个反应) (0 位负责人)Ruby (30 个派生)auto 404
help wantedready

仓库指标

星标
 (12 个星标)
PR 合并指标
 (PR 指标待抓取)

描述

Right now, the show matcher ignores what is passed to expect. It just looks to see if the specified page object is anywhere on the page. When we expect one page object to be a child of another, it would be nice to be able to say something like

expect(dashboard).to show :deed_form

This example comes from user_logs_deed_spec.rb. Right now, we can only assert that both objects are on the page:

expect(page).to show :deed_form
expect(page).to show :dashboard

With the way things are now if we were to say expect(dashboard).to show :deed_form it would pass, even if the deed form wasn't a child of the dashboard but was elsewhere on the page.

贡献者指南