Graylog2/graylog2-server

Don't sort output config fields by optionality

Open

#4,761 创建于 2018年4月25日

在 GitHub 查看
 (3 评论) (0 反应) (0 负责人)Java (6,945 star) (1,032 fork)batch import
good first issuepapercuttriaged

描述

Expected Behavior

The config fields of my output plugin appear in the order I registered them.

Current Behavior

If some of them are optional, they are shown below all others.

Possible Solution

Don't sort the fields by optionality.

Steps to Reproduce (for bugs)

Register two output config fields and make the first optional.

Context

https://github.com/Graylog2/graylog2-server/pull/4746#issuecomment-384253076

Your Environment

(not relevant)

贡献者指南

技术栈
javajavascriptreact
领域
frontend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
familiarity with React componentsunderstanding of Graylog configuration forms
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
75
研究方向
The issue is in the ConfigurationForm.jsx component, specifically at line 156 where fields are sorted by optionality. The fix is to remove or modify this sorting to preserve the original registration order. Refer to linked PR #4746 and comment for context. No additional changes to other parts of the codebase are required.
Don't sort output config fields by optionality · Graylog2/graylog2-server#4761 | Good First Issue