GoogleContainerTools/skaffold

Refactor code and remove duplication

Open

#7,318 创建于 2022年4月15日

在 GitHub 查看
 (0 评论) (0 反应) (0 负责人)Go (12,822 star) (1,416 fork)batch import
help wantedkind/starter-projectkind/todopriority/p3

描述

This task is about remove code duplication.

The skaffold filter command was added to apply debug transformations to configure container images for debugging. See here -> https://skaffold.dev/docs/workflows/debug/#configuring-container-images-for-debugging

When skaffold filter command was added it did not need any information from the run context.

However, after @aaron-prindle added the Resource Selector config where users can configure which resource types to transform. These list now needs to be passed to Filter command. In #7317, @tejal29 duplicated the functionality in getTransformList

The right way to do this is, Add Filter() method to the SkaffoldRunner which has access to the runner.RunContext.TransformAllowList and runCtx.runner.RunContext.TransformDenyList

The new Filter method will additionally execute the runFilter in here

贡献者指南

技术栈
go
领域
clidevopsinfrastructure
议题类型
refactor
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Go programmingskaffold codebase
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
65
研究方向
The implementation requires adding a Filter() method to the SkaffoldRunner that uses TransformAllowList and TransformDenyList from runner.RunContext (see pkg/skaffold/runner/runcontext/context.go lines 111+). This method should execute the runFilter logic currently in cmd/skaffold/app/cmd/filter.go line 59. The duplicated getTransformList function in the filter command should be removed and replaced by calling the new Filter method. The existing test suite for filter should be updated to cover the new implementation.