GoogleContainerTools/skaffold

Configuration dependencies don't resolve paths to deploy hooks

Open

#7,250 创建于 2022年3月31日

在 GitHub 查看
 (10 评论) (0 反应) (0 负责人)Go (12,822 star) (1,416 fork)batch import
area/hookshelp wantedkind/bugpriority/p3

描述

Expected behavior

When having a toplevel configution like this:

apiVersion: skaffold/v2beta25
kind: Config
requires:
  - configs: ["cfg1"]
    path: cfg1/skaffold.yaml
  - configs: ["cfg2"]
    path: cfg2/skaffold.yaml

When the skaffold.yaml files in ./cfg1 and ./cfg2 define deploy hooks, the paths to these hooks should resolved relative to the ./cfg1, or ./cfg2 directory. For instance if ./cfg2 has:

deploy:
  kubectl:
    manifests:
    - deploy/kubernetes.yaml
    hooks:
      before:
        - host:
            command: ["sh", "-c", "deploy/skaffold-before-hook.sh"]

it should look for skaffold-before-hook.sh in ./cfg2/deploy/ and not in ./deploy. Also, any files that are created or referenced by this hook should be relative to ./cfg2

Actual behavior

hooks are resolved relative to the toplevel directory. I have to make a symlink ./deploy/skaffold-before-hook.sh --> ../cfg2/deploy/skaffold-before-hook.sh

Information

  • Skaffold version: 1.37.0
  • Operating system: Linux Ubuntu 20.04
  • Installed via: skaffold.dev

贡献者指南

技术栈
go
领域
clideveloper experience
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-2 days
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Go programming languageSkaffold tool basicsYAML configuration
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
50
研究方向
Investigate how Skaffold resolves paths for deploy hooks in dependent configs. Look at the code that processes the 'requires' field and the hook execution in the 'deploy' package. The fix likely involves ensuring that relative paths in hooks are resolved relative to the config file's directory. Check the configuration parsing logic in the 'pkg/skaffold/config' package and the deploy hook execution in 'pkg/skaffold/deploy'.