GoogleContainerTools/skaffold

Bug/feature req: Show errors from Lifecycle hook when it fails

Open

#7,019 创建于 2022年1月17日

在 GitHub 查看
 (3 评论) (0 反应) (0 负责人)Go (12,822 star) (1,416 fork)batch import
area/status-checkhelp wantedkind/enhancementpriority/p3

描述

Expected behavior

If a lifecycle hook fails, and the pod fails to start up, its "invisible" to the skaffold user, I expected it to log events from the lifecycle hooks.

Actual behavior

Waiting, and then terminating without any obvious reason to why

Information

  • Skaffold version: 1.29.0
  • Operating system: Fedora 32
  • Installed via: gcloud components / package manager

Steps to reproduce the behavior

Event logs fetch via Lens:

Exec lifecycle hook ([php bin/console cache:warmup -n]) for Container "eportal" in Pod "eportal-6cc67c6456-sgb9z_morten(b3217653-88da-4970-955d-8012e1aed6d6)" failed - error: command 'php bin/console cache:warmup -n' exited with 1: In DefinitionErrorExceptionPass.php line 54: Cannot autowire service "App\Controller\ApiOperations\Group\GetAvailableGro upMeetings": argument "$request" of method "__construct()" references class "Symfony\Component\HttpFoundation\Request" but no such service exists. , message: "\nIn DefinitionErrorExceptionPass.php line 54:\n \n Cannot autowire service \"App\\Controller\\ApiOperations\\Group\\GetAvailableGro \n upMeetings\": argument \"$request\" of method \"__construct()\" references class \n \"Symfony\\Component\\HttpFoundation\\Request\" but no such service exists. \n \n\n"

贡献者指南

技术栈
gokubernetesdocker
领域
backenddevops
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
needs investigation
前置要求
Goskaffold lifecycle hooksKubernetes pod lifecycle
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
40
研究方向
Examine how Skaffold runs lifecycle hooks in deploy/deploy.go and related files. Look for where the hook command output is captured or lost. The issue suggests that when a hook fails, Skaffold does not log the error. Find the code that executes the hook and check if the output is being printed to the user. Consider adding logic to log the hook's stderr/stdout on failure.