GoogleChromeLabs/quicklink

Do not prefetch links with `download` attribute

Open

#181 创建于 2020年5月15日

在 GitHub 查看
 (1 评论) (1 反应) (0 负责人)JavaScript (10,861 star) (431 fork)batch import
enhancementgood first issue

描述

Is your feature request related to a problem? Please describe. Currently all links are prefetched including ones intended for downloadable assets. Since these links could point to large payloads (imagine multi megabyte PDFs or zip archives) that's quite a waste of bandwidth.

I'd argue excluding links which have the download attribute would be a sensible default.

Describe the solution you'd like

document.querySelectorAll('a:not([download])')

Thank you :)

贡献者指南

技术栈
javascripthtml
领域
frontendperformance
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
under 1 hour
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Basic JavaScriptDOM querySelectorsQuicklink library structure
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
80
研究方向
Locate the code in quicklink's source where links are selected for prefetching, likely in the main prefetch function. Modify the query selector to exclude links with the `download` attribute. Ensure that the change is applied consistently across any link collection logic. No additional changes required beyond the selector update.