Consider adding `rootMargin` to the Intersection Observer · GoogleChromeLabs/quicklink#14 | Good First Issue

(13 评论) (1 反应) (0 负责人)JavaScript (431 fork)batch import

enhancementgood first issuehelp wanted

仓库指标

Star: (10,861 star)
PR 合并指标: (平均合并 47天 12小时) (30 天内合并 4 个 PR)

描述

Feedback from @surma:

I feel like by default you should add a rootMargin to the IO to trigger the load before something comes into the viewport.

So, rootMargin defaults to "0px 0px 0px 0px", meaning the intersection will be computed between the root element's unmodified bounds rectangle and the target's bounds. This change would be made to https://github.com/GoogleChromeLabs/quicklink/blob/master/src/index.mjs#L21

贡献者指南

研究方向: 修改 src/index.mjs 中的 IntersectionObserver 构造函数调用，使其接受可选的 rootMargin 参数，默认为 '0px 0px 0px 0px'，并相应地更新函数签名和文档。
技术栈: javascript
领域: frontend
议题类型: 功能
难度: 2
预计时间: 1-3 小时
活动状态: 活跃
清晰度: 清晰
前置要求: JavaScriptIntersection Observer API
新手友好度: 70