GoogleChromeLabs/quicklink

Consider adding `rootMargin` to the Intersection Observer

Open

#14 创建于 2018年12月10日

在 GitHub 查看
 (13 评论) (1 反应) (0 负责人)JavaScript (10,861 star) (431 fork)batch import
enhancementgood first issuehelp wanted

描述

Feedback from @surma:

I feel like by default you should add a rootMargin to the IO to trigger the load before something comes into the viewport.

So, rootMargin defaults to "0px 0px 0px 0px", meaning the intersection will be computed between the root element's unmodified bounds rectangle and the target's bounds. This change would be made to https://github.com/GoogleChromeLabs/quicklink/blob/master/src/index.mjs#L21

贡献者指南

技术栈
javascript
领域
frontendperformance
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Intersection Observer APIJavaScriptquicklink library structure
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
70
研究方向
Review the conversation in the comments to understand desired behavior. The change needs to be made in src/index.mjs around line 21 where the Intersection Observer is instantiated. Ensure the rootMargin option is exposed and defaults to '0px 0px 0px 0px' if not provided. Test that prefetching triggers earlier with a non zero rootMargin.