GoogleChrome/lighthouse

runWarnings format difficult for pragmatic usage

Open

#11,352 创建于 2020年9月1日

在 GitHub 查看
 (4 评论) (0 反应) (0 负责人)JavaScript (27,768 star) (9,278 fork)batch import
P3breakinggood first issue

描述

I have two concerns with runWarnings specifically around pragmatic usage:

  • runWarnings contains both errors (eg, page hung / non-successful request on main document resource) and warnings (eg, CPU throttling might be bad)
  • The errors and warnings contained within runWarnings are strings. There's no handle to be able to identify one warning/error from another, without searching the string.

Feature request summary

runWarnings to be changed to an object. It should contain code and message. Just like runtimeError.

What is the motivation or use case for changing this?

Node.js/API/PageSpeed users of Lighthouse will be able to handle errors/warnings reliably.

贡献者指南

技术栈
javascriptnodejs
领域
apideveloper experiencetooling
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Familiarity with LighthouseJavaScriptNode.js
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
75
研究方向
Locate where `runWarnings` is generated in the Lighthouse codebase (likely in the report or gathering phase). Currently it is an array of strings; modify it to output an array of objects with `code` and `message` fields, similar to `runtimeError`. Update any consumers of `runWarnings` to handle the new format, and ensure tests pass.