GeertJohan/go.rice

rice append doesn't append compressed zip contents, but plain text?

Open

#84 创建于 2016年10月3日

在 GitHub 查看
 (7 评论) (1 反应) (0 负责人)Go (2,442 star) (187 fork)user submission
enhancementhelp wanted

描述

Appending two boxes (templates and assets folder), I can inspect the binary files and realize that the appended data is not compressed at all:

--- ping-dashboard-orig.hex     2016-10-03 15:11:35.050537200 +0200
+++ ping-dashboard.hex  2016-10-03 15:08:22.578537200 +0200
@@ -418688,3 +418688,8226 @@
 06637f0: 0000 0000 0000 0000 1031 6600 0000 0000  .........1f.....
 0663800: d000 0000 0000 0000 0000 0000 0000 0000  ................
 0663810: 0100 0000 0000 0000 0000 0000 0000 0000  ................
+0663820: 504b 0304 1400 0000 0000 0000 0000 0000  PK..............
+0663830: 0000 0000 0000 0000 0000 0900 0000 7465  ..............te
+0663840: 6d70 6c61 7465 7350 4b03 0414 0000 0000  mplatesPK.......
+0663850: 0034 5a43 49e5 6bc7 bb73 0e00 0073 0e00  .4ZCI.k..s...s..
+0663860: 0013 0000 0074 656d 706c 6174 6573 2f6d  .....templates/m
+0663870: 6169 6e2e 6874 6d6c 3c21 444f 4354 5950  ain.html<!DOCTYP
+0663880: 4520 6874 6d6c 3e0a 3c68 6561 643e 0a3c  E html>.<head>.<
+0663890: 6d65 7461 2063 6861 7273 6574 3d22 7574  meta charset="ut
+06638a0: 662d 3822 3e0a 3c6c 696e 6b20 7265 6c3d  f-8">.<link rel=
+06638b0: 2273 7479 6c65 7368 6565 7422 2074 7970  "stylesheet" typ
+06638c0: 653d 2274 6578 742f 6373 7322 2068 7265  e="text/css" hre
+06638d0: 663d 222f 2f66 6f6e 7473 2e67 6f6f 676c  f="//fonts.googl
+06638e0: 6561 7069 732e 636f 6d2f 6373 733f 6661  eapis.com/css?fa
+06638f0: 6d69 6c79 3d4f 7065 6e2b 5361 6e73 2220  mily=Open+Sans"
+0663900: 2f3e 0a3c 7374 796c 6520 7479 7065 3d22  />.<style type="
+0663910: 7465 7874 2f63 7373 2220 6d65 6469 613d  text/css" media=
+0663920: 2273 6372 6565 6e22 3e0a 0962 6f64 7920  "screen">..body
+0663930: 7b0a 0909 6261 636b 6772 6f75 6e64 3a20  {...background:
+0663940: 2330 3030 3b0a 0909 636f 6c6f 723a 2023  #000;...color: #
+0663950: 6666 663b 0a09 7d0a 092a 207b 0a09 0966  fff;..}

I'm expecting the zip file would be compressed which doesn't seem to be the case...

贡献者指南

技术栈
go
领域
tooling
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Go programmingzip compression concepts
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
50
研究方向
Investigate the `rice append` command implementation in the go.rice repository. Focus on how boxes are serialized and appended, specifically the compression step. The hex dump in the issue shows that the zip data is stored uncompressed, suggesting that the compression flag is not properly set. Check the relevant source files (e.g., `rice/append.go`) and any test files, and review the comments on the issue for additional context.
rice append doesn't append compressed zip contents, but plain text? · GeertJohan/go.rice#84 | Good First Issue