Galooshi/import-js

ImportJS misidentifies `import` methods to be Dynamic Import

Open

#529 创建于 2019年3月18日

在 GitHub 查看
 (3 评论) (0 反应) (0 负责人)JavaScript (519 star) (70 fork)batch import
bughelp wanted

描述

I just run ImportJS on a huge codebase and the results are mostly good, but this one seemed peculiar enough for me to report it:

I'm not too familiar with the lib, but in this case it broke the code by sorting two variable assignments in false order.

Used ImportJS 3.2.0 on Mac OS, via CLI:

find ./client -name "**.js*" -exec importjs fix --overwrite {} \;

//.importjs.js
module.exports = {
    declarationKeyword: 'import',
    environments: ['meteor', 'node'],
    excludes: ['.meteor/local/**', '.vscode/**'],
    mergableOptions: {
        globals: false,
    },
    useRelativePaths: true
}

贡献者指南

技术栈
javascript
领域
toolingdeveloper experience
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
Basic knowledge of JavaScript module systemUnderstanding of static vs dynamic imports
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
45
研究方向
The issue reports that ImportJS incorrectly identifies certain import methods as dynamic imports, causing incorrect sorting of variable assignments. Investigate the parsing logic in the source code, likely in the `import js` package's detection of import statements. Look at how the library distinguishes between static and dynamic imports, and check for any edge cases in regex or AST parsing. The screenshot shows an example where two import like lines are sorted wrongly. Focus on the function that handles import identification and sorting, and try to reproduce the issue with the provided configuration.