FuelLabs/sway

Delete redundant spans in `sway_error::error`

Open

#4,818 创建于 2023年7月18日

在 GitHub 查看
 (7 评论) (0 反应) (1 负责人)Rust (61,702 star) (5,421 fork)batch import
ODHack13compilercompiler: uigood first issuemay be rewardedteam:compiler

描述

Now when Idents are used instead of strings, those redundant spans are really annoying and bloating the code.

See this TODO.

When removing those redundant spans we can have a situation that deduplication of error messages might remove errors that are actually not duplicates because although they point to the same Ident (in terms of name), their Spans can be different. Deduplication works on hashes and Ident's hash contains only the name and not the span.

That's why we should always using IdentUnique.

贡献者指南

技术栈
rust
领域
backend
议题类型
refactor
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
blocked
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
Rustsway error system basics
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
30
研究方向
Remove redundant Span fields in sway error/src/error.rs as per the TODO comment at line 26. Replace with IdentUnique to ensure deduplication uses only the identifier name, not the span. Update all callers and handle any hash based deduplication side effects. Test that identical identifiers with different spans are still deduplicated correctly.
Delete redundant spans in `sway_error::error` · FuelLabs/sway#4818 | Good First Issue