FuelLabs/fuel-core

Separate Execution Gas Price and DA Gas Price into separate newtypes to add clarity

Open

#2,382 创建于 2024年10月22日

在 GitHub 查看
 (2 评论) (0 反应) (1 负责人)Rust (57,084 star) (2,861 fork)batch import
good first issue

描述

It's been suggested that we separate the two just to help organize the code a bit better. Instead of just dealing withu64 everywhere, it could help the reader to have types to communicate everywhere in the code the purpose of the numbers.

贡献者指南

技术栈
rust
领域
backendblockchain
议题类型
refactor
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
half day
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
blocked
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Basic Rust knowledgeUnderstanding of gas pricing in FuelFamiliarity with newtype pattern
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
40
研究方向
Review the discussion in PR #2364, specifically the comment that suggested separating the types. Then identify all occurrences of `u64` representing gas prices in the codebase, distinguishing between execution gas price and DA gas price. Create two newtypes, e.g., `ExecutionGasPrice` and `DaGasPrice`, implementing necessary traits (e.g., arithmetic, serialization), and refactor all usages to use them. Consult the linked PR for additional context and potential pitfalls.