FreeCAD/FreeCAD

PartDesign: Hole thread pitch tests

开放

#21,195 创建于 2025年5月7日

 (6 条评论) (0 个反应) (1 位负责人)C++ (5,550 个派生)batch import
Help wantedMod: Part DesignType: Code Quality

仓库指标

星标
 (30,913 个星标)
PR 合并指标
 (平均合并 24天 7小时) (30 天内合并 217 个 PR)

描述

Is there an existing issue for this?

  • I have searched the existing issues

Problem description

The PR https://github.com/FreeCAD/FreeCAD/pull/21015 fixes an important issue but could be improved as discussed in the comments.

  • refactor to use std::ranges::min_element
  • prioritize same dimension over pitch
  • unit tests.

This issue is to track the small technical debt added by merging it before that's been fixed.

Full version info

N/A

Subproject(s) affected?

None

Anything else?

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct

贡献者指南