FluxML/Flux.jl

Separate nightly CI from posted CI badge

开放

#2,237 创建于 2023年4月23日

 (2 条评论) (0 个反应) (0 位负责人)Julia (619 个派生)batch import
discussiongood first issuetesting

仓库指标

星标
 (4,725 个星标)
PR 合并指标
 (平均合并 3天 6小时) (30 天内合并 6 个 PR)

描述

Inspired from a discussion on Slack about how other packages handle the same. Flux frequently has to deal with this because new nightly releases often break Zygote, but Flux itself is rarely affected. There seem to be two main approaches to accomplishing this:

  1. Allow the nightly CI job to fail, e.g. https://github.com/JuliaSmoothOptimizers/SolverTest.jl/pull/6. This is simple to implement but does risk missing real failures if one doesn't dig beyond the big green checkmark.
  2. Separate nightly CI into its own job and show the non-nightly results badge, e.g. https://github.com/JuliaManifolds/Manifolds.jl/blob/master/.github/workflows/nightly.yml. This is more work but will still fail loudly for PRs.

A related question is whether we want to do the same for downstream tests. There are some known downstreams which are quite flaky, but since we don't include any downstream results in the README I'd assume this is less of a problem.

贡献者指南