Flow-Launcher/Flow.Launcher

BUG: Calculator can't multiply numbers with more than 19 digits

Open

#2,673 创建于 2024年4月25日

在 GitHub 查看
 (5 评论) (0 反应) (0 负责人)C# (14,678 star) (598 fork)batch import
bughelp wantedkeep-fresh

描述

Checks

  • I have checked that this issue has not already been reported.

  • I am using the latest version of Flow Launcher.

Problem Description

Calculator is providing wrong result if one of the two numbers being multiplied is more than 19 digits. Examples:

  1. 1.2*0.83333333333333333333
  2. 2453*23534245034253633353
  3. 1*0.22222222222222222222
  4. 1*24353532424240053022
  5. 1*1111111111111111111111
  6. 1324*30000000000000000000

It's easiest to see this issue in action if you copy and paste the above examples and then remove just the last digit. We will notice a large change in the result.

But there are some instances where this doesn't happen. I am unable to determine the logic behind when this issue occurs and when it does not. Examples:

  1. 1*0.11111111111111111111
  2. 1324*10000000000000000000
  3. 1324*40000000000000000000

To Reproduce

No response

Screenshots

No response

Flow Launcher Version

1.18.0

Windows Build Number

10.0.22631.3447

Error Log

No response

贡献者指南

技术栈
csharp
领域
desktop
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
fresh
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
C#basic understanding of numeric types
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
70
研究方向
Examine the calculator plugin's multiplication implementation, likely in C# code. Check for usage of double vs decimal or BigInteger. Identify where precision loss occurs. Refer to issue examples and any comments for additional context. Propose switching to decimal or BigInteger if needed.