GestureHandler doesn't fire "tap" for IE<11 · Famous/engine#323

(2 评论) (0 反应) (0 负责人)JavaScript (1,750 star) (262 fork)batch import

bughelp wanted

描述

GestureHandler doesn't work for IE 10 and below. In famous-carousel, I've worked around it by calling this directly on the DOM element when IE is detected:

arrowEl.attachEvent("onclick", emitPageChange);

MS docs say addEventListener should work for IE 9+, but this doesn't seem to be the case. I could only get it to recognize clicks by calling attachEvent.

I loathe IE as much as anyone, but there are still a lot of systems running IE 9 & 10 and Famo.us does run on them for the most part. I looked through the engine code and from what I can tell, DOMElement.prototype.on() might be the place to modify. Would something like this be better placed under polyfills, if the Famo.us team finds it acceptable?

贡献者指南

技术栈: javascript
领域: frontend
议题类型: bug
难度: 3
预计时间: half day
活动状态: stale
清晰度: clear
前置要求: Familiarity with JavaScript DOM eventsUnderstanding of browser compatibilityKnowledge of polyfills
新手友好度: 40
研究方向: Investigate the DOMElement.prototype.on method in Famous Engine's codebase. The user suggests adding an attachEvent fallback for IE<11. Review existing polyfills in the project to determine if a similar approach is used elsewhere. The issue mentions that addEventListener doesn't work for IE9/10, so testing with those browsers is necessary. Check comments on the issue for any additional insights or prior attempts.