Fallout-build/Fallout

Rename legacy s_-prefixed private fields to camelCase and enforce the rule

已关闭

#481 创建于 2026年7月12日

 (3 条评论) (0 个反应) (0 位负责人)C# (16 个派生)github user discovery
enhancementgood first issuetarget/backlog

仓库指标

星标
 (125 个星标)
PR 合并指标
 (平均合并 2天 15小时) (30 天内合并 63 个 PR)

描述

Problem

.editorconfig:73-85 mandates camelCase private fields (no _/m_/g_/s_ prefix, per CSharpGuidelines AV1702/AV1705) but keeps severity = suggestion because ~35 legacy s_-prefixed identifiers across ~34 files still violate it (e.g. Telemetry.s_confirmedVersion). The convention is documented but not compiler-enforced, so new violations slip in. Surfaced in #451 review.

Outcome

No prefixed private fields remain; the naming rule is warning, so new violations fail the build.

Acceptance criteria

  • All s_/_/m_/g_-prefixed private fields in src/**/*.cs renamed to camelCase
  • dotnet_naming_rule.private_fields_should_be_camel_case.severity bumped suggestionwarning (.editorconfig:78)
  • Build green with no new naming warnings

Notes

Mechanical rename; exclude generated code. Low priority.

贡献者指南