Esri/arcgis-rest-js

`isItemSharedWithGroup` returns `undefined` instead of false.

开放

#665 创建于 2020年3月3日

 (2 条评论) (0 个反应) (0 位负责人)TypeScript (126 个派生)auto 404
good first issuehelp wanted

仓库指标

星标
 (389 个星标)
PR 合并指标
 (PR 指标待抓取)

描述

The return statement in isItemSharedWithGroup is incorrectly nested in an if block. This one flies under the radar because undefined is falsy, but it's a bug nonetheless.

function isItemSharedWithGroup(requestOptions) {
  var searchOpts = {
    q: "id: " + requestOptions.id + " AND group: " + requestOptions.groupId,
    start: 1,
    num: 10,
    sortField: "title",
    authentication: requestOptions.authentication,
    httpMethod: "POST"
  };
  return Object(_items_search__WEBPACK_IMPORTED_MODULE_7__["searchItems"])(searchOpts).then(function (searchResponse) {
    var result = false;

    if (searchResponse.total > 0) {
      result = searchResponse.results.some(function (itm) {
        return itm.id === requestOptions.id;
      });
      return result; // SHOULD BE OUTSIDE THE IF BLOCK
    }
  });
}

贡献者指南