DLR-FT/wasm-interpreter

Security concern: CI could leak github secrets

开放

#297 创建于 2025年11月30日

 (1 条评论) (2 个反应) (3 位负责人)Rust (5 个派生)auto 404
bughelp wantedpriority-highworkflows

仓库指标

星标
 (37 个星标)
PR 合并指标
 (平均合并 5天 12小时) (30 天内合并 16 个 PR)

描述

I was recently watching a video about NPM's supply chain attack, and how its starting point was the exploitation of a github action. We may be vulnerable to a similar attack to on this repo by a willing malicious actor.

The culprit is on: pull_request_target. This is used in 2 places in our CI: testsuite_preview.yaml and labeler.yaml. The labeler workflow is probably safe (?), but the testsuite_preview is likely exploitable. See this article: https://shreyapohekar.com/blogs/how-attackers-exploit-pull_request_target-secure-your-github-ci-cd-workflows/ . We do exactly what we shouldn't do.

The purpose of that pull_request_target was to be able to have the workflow work for PRs sent from forks.

See also: https://www.wiz.io/blog/s1ngularity-supply-chain-attack

I recommend disabling the PR until a proper security analysis of the pipeline can be done. I unfortunately do not have the time to look into this myself, but please do look into this. I am concerned ☹️

Make sure to disable/remove/fix this CI from other branches as well, not just main.

贡献者指南