CommunityToolkit/WindowsCommunityToolkit

WeakEventListener in NetworkConnectionStateTrigger is duplicated

Open

#4,059 创建于 2021年6月1日

在 GitHub 查看
 (1 评论) (0 反应) (1 负责人)C# (5,708 star) (1,403 fork)batch import
Hacktoberfestbug :bug:good first issuehelp wantedimprovements :sparkles:

描述

Describe the bug

Looks like NetworkConnectionStateTrigger is using a private copy of WeakEventListener, it's identical to the one we already have in the Toolkit, so we should update the source to use the existing code within the Toolkit.

https://github.com/windows-toolkit/WindowsCommunityToolkit/blob/ebb12e0c38c22ec01849e202f8e477d8c1a67061/Microsoft.Toolkit.Uwp.UI/Triggers/NetworkConnectionStateTrigger.cs#L73

Expected behavior

Use existing code over shadow copy.

https://github.com/windows-toolkit/WindowsCommunityToolkit/blob/ebb12e0c38c22ec01849e202f8e477d8c1a67061/Microsoft.Toolkit.Uwp/Helpers/WeakEventListener.cs#L17

贡献者指南

技术栈
csharp
领域
frontend
议题类型
refactor
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
under 1 hour
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
C#Windows Community Toolkit structure
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
80
研究方向
The issue identifies a duplicated WeakEventListener in NetworkConnectionStateTrigger.cs (path: Microsoft.Toolkit.Uwp.UI/Triggers/NetworkConnectionStateTrigger.cs). The fix involves removing the private copy and replacing its usage with the existing WeakEventListener in Microsoft.Toolkit.Uwp/Helpers/WeakEventListener.cs. Check the file at line 73 for the duplicated class, then update using directives and references to point to the shared helper. Ensure no breaking changes and that the namespace is correctly imported.