WeakEventListener in NetworkConnectionStateTrigger is duplicated · CommunityToolkit/WindowsCommunityToolkit#4059 | Good First Issue

(1 评论) (0 反应) (1 负责人)C# (1,403 fork)batch import

Hacktoberfestbug :bug:good first issuehelp wantedimprovements :sparkles:

仓库指标

Star: (5,708 star)
PR 合并指标: (30 天内没有已合并 PR)

描述

Describe the bug

Looks like NetworkConnectionStateTrigger is using a private copy of WeakEventListener, it's identical to the one we already have in the Toolkit, so we should update the source to use the existing code within the Toolkit.

https://github.com/windows-toolkit/WindowsCommunityToolkit/blob/ebb12e0c38c22ec01849e202f8e477d8c1a67061/Microsoft.Toolkit.Uwp.UI/Triggers/NetworkConnectionStateTrigger.cs#L73

Expected behavior

Use existing code over shadow copy.

https://github.com/windows-toolkit/WindowsCommunityToolkit/blob/ebb12e0c38c22ec01849e202f8e477d8c1a67061/Microsoft.Toolkit.Uwp/Helpers/WeakEventListener.cs#L17

贡献者指南

研究方向: 该问题识别出 NetworkConnectionStateTrigger.cs（路径：Microsoft.Toolkit.Uwp.UI/Triggers/NetworkConnectionStateTrigger.cs）中存在重复的 WeakEventListener。修复方法涉及移除该私有副本，并将其使用替换为 Microsoft.Toolkit.Uwp/Helpers/WeakEventListener.cs 中现有的 WeakEventListener。请检查第 73 行处的重复类，然后更新 using 指令和引用以指向共享的帮助程序。确保没有破坏性更改，并且命名空间已正确导入。
技术栈: csharp
领域: frontend
议题类型: 重构
难度: 1
预计时间: 1 小时以内
活动状态: 活跃
清晰度: 清晰
前置要求: C#Git
新手友好度: 85