CodeEditApp/CodeEdit

🐞 Sidebar tab panel state is not retained when returning to it from another tab

Open

#711 创建于 2022年8月3日

在 GitHub 查看
 (3 评论) (0 反应) (0 负责人)Swift (22,856 star) (1,165 fork)batch import
UIbuggood first issue

描述

Description

Any sidebar tab panel needs to retain the state it was in before navigating away to a new sidebar tab panel. This applies to both the left navigator sidebar and the right inspector sidebar.

To Reproduce

  1. Make sure you are in the Project Navigator
  2. Expand a few folders
  3. Scroll down
  4. Open the Find Navigator
  5. Open the Project Navigator
  6. Notice folders previously expanded are now collapsed and scroll position is at the top.

Expected behavior

Folders that were previously expanded should remain expanded and scroll position should be as you left it upon returning to the sidebar tab panel.

Version information

CodeEdit: 1.0 Hash: bb373d99ddd7c91e31d6fd5a75d96db4fdbb9b3a MacOS: 12.5 (21G72) Xcode: 13.4.1 (13F100)

贡献者指南

技术栈
swift
领域
desktop
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
half day
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
fresh
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Swift programmingBasic knowledge of SwiftUI state management
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
70
研究方向
The issue is about sidebar tab panels not retaining state. Look at the implementation of the sidebar tab views, possibly in files like `SidebarView.swift` or `NavigatorPanel.swift`. Investigate how state is managed when switching tabs. Consider using a view model with `@StateObject` or `@ObservableObject` to persist the state of each tab panel. Check if the tab panel views are being recreated each time the tab changes. A fix could involve storing the state in a parent view that remains alive, or using `onAppear`/`onDisappear` correctly.