CleverRaven/Cataclysm-DDA

Overmap coverage test needs to account for overmaps that spawn only in alternate Dimensions

Open

#84,557 创建于 2026年1月8日

在 GitHub 查看
 (0 评论) (2 反应) (0 负责人)C++ (9,264 star) (3,991 fork)batch import
<Suggestion / Discussion>Code: TestsHelp WantedMap / Mapgen

描述

Is your feature request related to a problem? Please describe.

When adding overmaps that only spawn in alternate dimensions (the terrains: "standing_stones_highlands", "highlands" can serve as an example here) you must forcibly add their entries to the overmap_terrain_coverage_whitelist to allow the test to pass.

Effectively this means that we dont check for special spawning errors in alternate dimensions

Solution you would like.

The test is expanded to cover alternate dimensions.

Describe alternatives you have considered.

No response

Additional context

No response

贡献者指南

技术栈
cpp
领域
testing
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
half day
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
fresh
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
C++overmap systemtest framework
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
50
研究方向
Investigate the overmap coverage test in the Cataclysm DDA codebase. Look for where overmap terrain whitelist is defined and how the current test fetches overmaps. The goal is to expand the test to also consider overmaps from alternate dimensions like 'standing stones highlands' and 'highlands'. Since this is a C++ project, relevant files are likely in src/ or data/. No linked PRs or maintainer comments are available.