CleverRaven/Cataclysm-DDA

Using toggle fast travel doesn't record map memory at all

Open

#76,350 创建于 2024年9月11日

在 GitHub 查看
 (5 评论) (0 反应) (0 负责人)C++ (9,264 star) (3,991 fork)batch import
(S2 - Confirmed)Code: Infrastructure / Style / Static AnalysisHelp WantedMap / Mapgen[C++]

描述

Describe the bug

When using the toggle fast travel option, it doesn't record map memory for your character. So if you decide to fast travel into an area that you have no map memory for, it will path there, but won't record any tiles.

Attach save file

TESTINGTWO-trimmed.tar.gz

Steps to reproduce

  1. Load save
  2. Fast travel to any nearby forest tile using 'toggle fast travel'
  3. Notice no map memory is updated

Expected behavior

Map memory should be recorded as if 'toggle fast travel' were off.

Screenshots

Just for clarification, I used the fast travel mechanic to get into this forest in the top-left spot, then directly east. I then disabled 'toggle fast travel' so that map view didn't stay open while traveling, and traveled south. As such, you have map memory when the option is disabled. image

Versions and configuration

  • OS: Windows
    • OS Version: 10.0.19045.4651 (22H2)
  • Game Version: cdda-experimental-2024-09-10-0339 c73e4c6 [64-bit]
  • Graphics Version: Tiles
  • Game Language: System language []
  • Mods loaded: [ Dark Days Ahead [dda], Disable NPC Needs [no_npc_food], Portal Storms Ignore NPCs [personal_portal_storms], Slowdown Fungal Growth [no_fungal_growth] ]

Additional context

No response

贡献者指南

技术栈
cpp
领域
backend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
active
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
C++ knowledgeunderstanding of fast travel system
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
50
研究方向
Examine the fast travel mechanic in the game code, specifically how map memory is updated when using toggle fast travel. Look at the 'map memory' and 'fast travel' related functions. Compare behavior when toggle is on versus off. The issue likely lies in a conditional that skips memory recording when toggle is active.