CleverRaven/Cataclysm-DDA

Tests: `guy != nullptr` randomly failing

Open

#73,352 创建于 2024年4月28日

在 GitHub 查看
 (3 评论) (0 反应) (0 负责人)C++ (9,264 star) (3,991 fork)batch import
<Bug>Code: TestsHelp Wanted[C++]

描述

Describe the bug

In all listed cases are also some armor display tests failing and this may be related. This specific random failure appears to be comparatively rare.

Unfortunately I lack the privileges in this repo to search through all workflow logs but I feel like I have seen this before. Can't prove it with additional links though.

Attach save file

Steps to reproduce

  1. Run tests.
  2. Win the rng lottery.
  3. Witness above failure.

Expected behavior

guy != nullptr

Screenshots

No response

Versions and configuration

n/a

Additional context

No response

贡献者指南

技术栈
cpp
领域
testing
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
fresh
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
C++ basicstest suite familiaritydebugging skillsgame logic understanding
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
65
研究方向
Examine the workflow logs linked in the issue to identify the exact assertion and stack trace. Search the test code for `guy != nullptr` to understand the context. Investigate the relationship between this test and the armor display tests that also fail randomly. Check if there is a race condition or missing initialization of the `guy` variable. Consider running the test multiple times locally to reproduce.