ChartsOrg/Charts

Default colors should adapt to macOS Mojave dark mode

Open

#3,742 创建于 2018年11月11日

在 GitHub 查看
 (4 评论) (0 反应) (0 负责人)Swift (28,002 star) (6,009 fork)batch import
help wanted

描述

What did you do?

Rendered a chart under dark mode in Mojave.

What did you expect to happen?

Labels, grids, etc, to show in white color.

What happened instead?

Labels, grids, etc, show in black.

Charts Environment

Charts version/Branch/Commit Number:master Xcode version:10.1 Swift version:4.2 Platform(s) running Charts:macOS macOS version running Xcode:10.14.1 Mojave

贡献者指南

技术栈
swift
领域
frontend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
half day
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
fresh
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Basic Swift knowledgeUnderstanding of macOS dark mode
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
50
研究方向
Implement color adaptation using NSAppearance or system colors. Identify where default colors are defined (likely in ChartColorTemplates or base chart components) and modify them to respond to the current appearance. Check for SwiftUI or AppKit approaches for dynamic colors. The issue is available as no PR is linked, but ensure the solution works for both light and dark modes.