Carthage/Carthage

Carthage should automaticalle use GITHUB_TOKEN instead of GITHUB_ACCESS_TOKEN when run on GitHub actions

开放

#3,058 创建于 2020年9月26日

 (2 条评论) (0 个反应) (0 位负责人)Swift (1,544 个派生)batch import
enhancementhelp wanted

仓库指标

星标
 (15,179 个星标)
PR 合并指标
 (30 天内没有已合并 PR)

描述

  • carthage install method: [ ] .pkg, [ ] homebrew, [ ] source [x] unsure, comes with GitHub actions
  • which carthage:
  • carthage version: 0.36.0
  • xcodebuild -version: Xcode 11.7 11E801a
  • Are you using --no-build? no
  • Are you using --no-use-binaries? no
  • Are you using --use-submodules? no
  • Are you using --cache-builds? no
  • Are you using --new-resolver? no

Cartfile.private

github "jspahrsummers/xcconfigs" "1ef9763"
github "Quick/Quick" ~> 2.0.0
github "Quick/Nimble" ~> 8.0.1

Running carthage build --no-skip-current && carthage archive to archive binaries from Mantle GitHub actions:

Carthage Output

*** Skipped downloading Nimble.framework binary due to the error:
8
	"API rate limit exceeded for 199.7.166.17. (But here's the good news: Authenticated requests get a higher rate limit. Check out the documentation for more details.)"
…

Actual outcome Carthage did not have an GITHUB_ACCESS_TOKEN set and got rate-limited.

Expected outcome Carthage should have used the GITHUB_TOKEN from the GitHub Actions environment instead.

贡献者指南