Carthage/Carthage

Fails to check out deppendency using git lfs

Open

#1,883 创建于 2017年4月14日

在 GitHub 查看
 (1 评论) (0 反应) (0 负责人)Swift (15,179 star) (1,544 fork)batch import
enhancementhelp wanted

描述

  • carthage version: 0.20.1
  • Are you using --use-submodules? Yes

Carthage doesn't handle repositories using git lfs on origin/HEAD. The general behavior is as follows:

  • Carthage clones repository to cache. LFS successfully smudges.
  • Carthage clones repository to Checkouts. Since remote is the cache, LFS smudge fails.

The failure happens before Carthage checks out the actually used branch.

Workaround: Create .lfsconfig as detailed in server discovery. This doesn't work well if you use SSH to access the repository.

Suggested fix:

Carthage could perform the equivalent of git clone --no-checkout initially, fix up the remote (which happens too late at the moment), then git checkout the resolved commit.

贡献者指南

技术栈
swift
领域
toolingdeveloper experience
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
half day
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Swift programmingCarthage internalsgit LFSGit clone workflows
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
50
研究方向
Investigate Carthage's cloning logic in the source code, particularly around the 'checkout' and 'cache' steps. The issue suggests modifying the process to perform a 'git clone no checkout' initially, then fix the remote URL, and finally checkout the resolved commit. Review the current implementation to understand where the LFS smudge fails and implement the suggested approach. Also consider adding tests for LFS scenarios.