Byron/trash-rs

Tests don't remove created files.

开放

#66 创建于 2023年5月2日

 (1 条评论) (0 个反应) (0 位负责人)Rust (40 个派生)auto 404
enhancementhelp wanted

仓库指标

星标
 (247 个星标)
PR 合并指标
 (30 天内没有已合并 PR)

描述

Running cargo test doesn't remove the files/folders created during tests as shown below. image Of course, these are mostly 0 bytes files but I think it is a little bit messy to leave them there, I can't think of any reason for not deleting them, but maybe I am missing something.

Proposed solution

As far as I could see, all tests are more or less of the form:

fn test_delete_file() {
    create_things_to_be_deleted();
    attempt_to_delete_using_trash();
    assert_deletion();
}

What I propose is adding one more block to the tests where we attempt to delete the created files like so.

fn test_delete_file() {
    create_things_to_be_deleted();
    attempt_to_delete_using_trash();
    delete_from_trash_manually();
    assert_deletion();
}

贡献者指南