BurntSushi/ripgrep

improve error messages when -f flag fails

Open

#478 创建于 2017年5月9日

在 GitHub 查看
 (9 评论) (0 反应) (0 负责人)Rust (63,768 star) (2,559 fork)batch import
enhancementhelp wanted

描述

For example:

$ rg -e foo -f src/search_stream.rs 
Error parsing regex near 'fer.|*/|z{' at character offset 213: Invalid application of repetition operator to: '(?u:f)(?u:o)(?u:o)|(?u:/)*(?u:!)|(?u:T)(?u:h)(?u:e)

Aside from the badly formatted regex error message (see #395), the error message should show the file path and probably also the line number at which the error occurred.

贡献者指南

技术栈
rust
领域
clideveloper experience
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
fresh
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Rustfamiliarity with ripgrep's error handling
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
70
研究方向
Investigate the error handling in ripgrep's regex parsing, particularly in the handling of the f flag. Look at the error formatting code in the regex module (e.g., src/regex.rs) to identify where regex errors are generated and how to attach file path and line number. Consider the existing patterns for error messages, and ensure the new format is consistent. Review issue #395 for context on badly formatted regex error messages.
improve error messages when -f flag fails · BurntSushi/ripgrep#478 | Good First Issue