BetterErrors/better_errors

allow custom favicon

Open

#362 创建于 2017年3月8日

在 GitHub 查看
 (4 评论) (0 反应) (0 负责人)Ruby (6,874 star) (433 fork)batch import
enhancementgood first issue

描述

we have some pages that use a different favicon (or non .ico icons)

I think custom path might be the way to go, since that favicon caches are super long

Many thanks for such great errors

贡献者指南

技术栈
ruby
领域
frontend
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Ruby basicsRack basics
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
60
研究方向
The issue requests adding a configuration option for custom favicon path. The current implementation likely uses a default favicon. Implementation would involve adding an option to the configuration module (e.g., `BetterErrors.configure` block) and using that path in the error page HTML. The commenters may have suggestions; check the issue discussion at https://github.com/BetterErrors/better errors/issues/362 for any proposed solutions or blockers.