B-Lang-org/bsc

Generate appropriate empty argument lists for Verilog system tasks/functions

开放

#304 创建于 2021年2月3日

 (0 条评论) (0 个反应) (0 位负责人)Haskell (178 个派生)batch import
good first issuepre-github

仓库指标

星标
 (1,108 个星标)
PR 合并指标
 (平均合并 17天 1小时) (30 天内合并 18 个 PR)

描述

When system tasks appear in the generated Verilog, this code in Verilog.hs omits the parenthesis when there are no arguments:

-- no parens when calling a task if it has no arguments                                                                                   
pPrint d p (VTask task []) = pPrint d 0 task <> text ";"

This was probably added because that is how the Verilog standard says that $finish should be written. However, for $fflush, the standard says that it must have empty parentheses, and some tools will be sticklers and issue a warning if the parentheses are missing.

The pPrint code will probably need to check the task name, to handle each specifically.

This is bug 1925 in Bluespec Inc's pre-GitHub bug database.

贡献者指南